From c5b542a333cfc021010c281b9f25f2ebd9ccfe9f Mon Sep 17 00:00:00 2001
From: Fabian Wiesel <fabian.wiesel@gmail.com>
Date: Sun, 25 Feb 2024 22:10:26 +0100
Subject: [PATCH] Unused arguments and unnessecary null checks

---
 .../childmonitor/DiscoverActivity.kt          | 33 +++++++++----------
 .../rochefort/childmonitor/MonitorActivity.kt |  7 ++--
 .../rochefort/childmonitor/StartActivity.kt   |  4 +--
 3 files changed, 21 insertions(+), 23 deletions(-)

diff --git a/app/src/main/kotlin/de/rochefort/childmonitor/DiscoverActivity.kt b/app/src/main/kotlin/de/rochefort/childmonitor/DiscoverActivity.kt
index 0cd56ad..e10be6e 100644
--- a/app/src/main/kotlin/de/rochefort/childmonitor/DiscoverActivity.kt
+++ b/app/src/main/kotlin/de/rochefort/childmonitor/DiscoverActivity.kt
@@ -44,9 +44,9 @@ class DiscoverActivity : Activity() {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_discover)
         val discoverChildButton = findViewById<Button>(R.id.discoverChildButton)
-        discoverChildButton.setOnClickListener { v: View? -> loadDiscoveryViaMdns() }
+        discoverChildButton.setOnClickListener { _: View? -> loadDiscoveryViaMdns() }
         val enterChildAddressButton = findViewById<Button>(R.id.enterChildAddressButton)
-        enterChildAddressButton.setOnClickListener { v: View? -> loadDiscoveryViaAddress() }
+        enterChildAddressButton.setOnClickListener { _: View? -> loadDiscoveryViaAddress() }
     }
 
     private fun loadDiscoveryViaMdns() {
@@ -69,7 +69,7 @@ class DiscoverActivity : Activity() {
         } else {
             portField.setText("10000")
         }
-        connectButton.setOnClickListener { v: View? ->
+        connectButton.setOnClickListener { _: View? ->
             Log.i(TAG, "Connecting to child device via address")
             val addressString = addressField.text.toString()
             val portString = portField.text.toString()
@@ -93,23 +93,19 @@ class DiscoverActivity : Activity() {
 
     override fun onDestroy() {
         Log.i(TAG, "ChildMonitoring stop")
-        if (discoveryListener != null) {
+        if (this.discoveryListener != null) {
             Log.i(TAG, "Unregistering monitoring service")
-            nsdManager!!.stopServiceDiscovery(discoveryListener)
-            discoveryListener = null
+            this.nsdManager!!.stopServiceDiscovery(discoveryListener)
+            this.discoveryListener = null
         }
         super.onDestroy()
     }
 
-    fun startServiceDiscovery(serviceType: String) {
+    private fun startServiceDiscovery(serviceType: String) {
         val nsdManager = this.getSystemService(NSD_SERVICE) as NsdManager
-        if (nsdManager == null) {
-            Log.e(TAG, "Could not obtain nsdManager")
-            return
-        }
         val wifi = this.applicationContext.getSystemService(WIFI_SERVICE) as WifiManager
         val multicastReleaser: Runnable
-        multicastReleaser = if (wifi != null) {
+        multicastReleaser = run {
             val multicastLock = wifi.createMulticastLock("multicastLock")
             multicastLock.setReferenceCounted(true)
             multicastLock.acquire()
@@ -120,20 +116,21 @@ class DiscoverActivity : Activity() {
                     //dont really care
                 }
             }
-        } else {
-            Runnable {}
         }
         val serviceTable = findViewById<ListView>(R.id.ServiceTable)
         val availableServicesAdapter = ArrayAdapter<ServiceInfoWrapper>(this,
                 R.layout.available_children_list)
         serviceTable.adapter = availableServicesAdapter
-        serviceTable.onItemClickListener = OnItemClickListener { parent: AdapterView<*>, view: View?, position: Int, id: Long ->
+        serviceTable.onItemClickListener = OnItemClickListener { parent: AdapterView<*>, _: View?, position: Int, _: Long ->
             val info = parent.getItemAtPosition(position) as ServiceInfoWrapper
-            connectToChild(info.address, info.port, info.name)
+            val address = info.address
+            if (address != null) {
+                connectToChild(address, info.port, info.name)
+            }
         }
 
         // Instantiate a new DiscoveryListener
-        discoveryListener = object : DiscoveryListener {
+        this.discoveryListener = object : DiscoveryListener {
             //  Called as soon as service discovery begins.
             override fun onDiscoveryStarted(regType: String) {
                 Log.d(TAG, "Service discovery started")
@@ -223,7 +220,7 @@ internal class ServiceInfoWrapper(private val info: NsdServiceInfo) {
         return info.host == other.host && info.port == other.port
     }
 
-    val address: String
+    val address: String?
         get() = info.host.hostAddress
     val port: Int
         get() = info.port
diff --git a/app/src/main/kotlin/de/rochefort/childmonitor/MonitorActivity.kt b/app/src/main/kotlin/de/rochefort/childmonitor/MonitorActivity.kt
index 30a2565..5edc4b6 100644
--- a/app/src/main/kotlin/de/rochefort/childmonitor/MonitorActivity.kt
+++ b/app/src/main/kotlin/de/rochefort/childmonitor/MonitorActivity.kt
@@ -39,7 +39,7 @@ class MonitorActivity : Activity() {
             // service that we know is running in our own process, we can
             // cast its IBinder to a concrete class and directly access it.
             val bs = (service as MonitorBinder).service
-            bs!!.setMonitorActivity(this@MonitorActivity)
+            bs.setMonitorActivity(this@MonitorActivity)
         }
 
         override fun onServiceDisconnected(className: ComponentName) {
@@ -85,8 +85,9 @@ class MonitorActivity : Activity() {
                     val linkAddresses = cm.getLinkProperties(network)!!.linkAddresses
                     for (linkAddress in linkAddresses) {
                         val address = linkAddress.address
-                        if (!address.isLinkLocalAddress && !address.isLoopbackAddress) {
-                            listenAddresses.add(address.hostAddress + " (" + networkInfo.typeName + ")")
+                        val hostAddress = address.hostAddress
+                        if (!address.isLinkLocalAddress && !address.isLoopbackAddress && hostAddress != null) {
+                            listenAddresses.add(hostAddress + " (" + networkInfo.typeName + ")")
                         }
                     }
                 }
diff --git a/app/src/main/kotlin/de/rochefort/childmonitor/StartActivity.kt b/app/src/main/kotlin/de/rochefort/childmonitor/StartActivity.kt
index fcc1ec3..e4b9d89 100644
--- a/app/src/main/kotlin/de/rochefort/childmonitor/StartActivity.kt
+++ b/app/src/main/kotlin/de/rochefort/childmonitor/StartActivity.kt
@@ -33,7 +33,7 @@ class StartActivity : Activity() {
         super.onCreate(savedInstanceState)
         setContentView(R.layout.activity_start)
         val monitorButton = findViewById<Button>(R.id.useChildDevice)
-        monitorButton.setOnClickListener { v: View? ->
+        monitorButton.setOnClickListener { _: View? ->
             Log.i(TAG, "Starting up monitor")
             if (isAudioRecordingPermissionGranted) {
                 startActivity(Intent(applicationContext, MonitorActivity::class.java))
@@ -42,7 +42,7 @@ class StartActivity : Activity() {
             }
         }
         val connectButton = findViewById<Button>(R.id.useParentDevice)
-        connectButton.setOnClickListener { v: View? ->
+        connectButton.setOnClickListener { _: View? ->
             Log.i(TAG, "Starting connection activity")
             if (isMulticastPermissionGranted) {
                 val i = Intent(applicationContext, DiscoverActivity::class.java)