pi/babyphone
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

remove unnecessary Runnable in onCreate()

Browse Source 
onCreate is already running on the UI thread, no need
to create a separate runnable.
This commit is contained in:
Branden Archer
2017-12-27 19:03:46 -05:00
parent 043c26481a
commit 1c64b15c00
2 changed files with 28 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
app/src/main/java/protect/babymonitor/ListenActivity.java
View File

@@ -105,28 +105,21 @@ public class ListenActivity extends Activity
setContentView(R.layout.activity_listen); setContentView(R.layout.activity_listen);
ListenActivity.this.runOnUiThread(new Runnable() NotificationCompat.Builder mBuilder =
{ new NotificationCompat.Builder(ListenActivity.this)
@Override .setOngoing(true)
public void run() .setSmallIcon(R.drawable.listening_notification)
{ .setContentTitle(getString(R.string.app_name))
NotificationCompat.Builder mBuilder = .setContentText(getString(R.string.listening));
new NotificationCompat.Builder(ListenActivity.this)
.setOngoing(true)
.setSmallIcon(R.drawable.listening_notification)
.setContentTitle(getString(R.string.app_name))
.setContentText(getString(R.string.listening));
_mNotifyMgr.notify(mNotificationId, mBuilder.build());
_mNotifyMgr.notify(mNotificationId, mBuilder.build()); final TextView connectedText = (TextView) findViewById(R.id.connectedTo);
connectedText.setText(_name);
final TextView connectedText = (TextView) findViewById(R.id.connectedTo); final TextView statusText = (TextView) findViewById(R.id.textStatus);
connectedText.setText(_name); statusText.setText(R.string.listening);
final TextView statusText = (TextView) findViewById(R.id.textStatus);
statusText.setText(R.string.listening);
}
});
_listenThread = new Thread(new Runnable() _listenThread = new Thread(new Runnable()
{ {

40
app/src/main/java/protect/babymonitor/MonitorActivity.java
View File

@@ -167,30 +167,24 @@ public class MonitorActivity extends Activity
}); });
_serviceThread.start(); _serviceThread.start();
MonitorActivity.this.runOnUiThread(new Runnable() final TextView addressText = (TextView) findViewById(R.id.address);
{
@Override // Use the application context to get WifiManager, to avoid leak before Android 5.1
public void run() final WifiManager wifiManager =
{ (WifiManager) getApplicationContext().getSystemService(WIFI_SERVICE);
final TextView addressText = (TextView) findViewById(R.id.address); final WifiInfo info = wifiManager.getConnectionInfo();
final int address = info.getIpAddress();
if(address != 0)
{
@SuppressWarnings("deprecation")
final String ipAddress = Formatter.formatIpAddress(address);
addressText.setText(ipAddress);
}
else
{
addressText.setText(R.string.wifiNotConnected);
}
// Use the application context to get WifiManager, to avoid leak before Android 5.1
final WifiManager wifiManager =
(WifiManager) getApplicationContext().getSystemService(WIFI_SERVICE);
final WifiInfo info = wifiManager.getConnectionInfo();
final int address = info.getIpAddress();
if(address != 0)
{
@SuppressWarnings("deprecation")
final String ipAddress = Formatter.formatIpAddress(address);
addressText.setText(ipAddress);
}
else
{
addressText.setText(R.string.wifiNotConnected);
}
}
});
} }
@Override @Override