pi/babyphone
1
0
Fork 0
Code Issues 3 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

remove unnecessary Runnable in onCreate()

Browse Source 
onCreate is already running on the UI thread, no need
to create a separate runnable.
This commit is contained in:
Branden Archer
2017-12-27 19:03:46 -05:00
parent 043c26481a
commit 1c64b15c00
2 changed files with 28 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/src/main/java/protect/babymonitor/ListenActivity.java
View File

@@ -105,11 +105,6 @@ public class ListenActivity extends Activity
setContentView(R.layout.activity_listen); setContentView(R.layout.activity_listen);
ListenActivity.this.runOnUiThread(new Runnable()
{
@Override
public void run()
{
NotificationCompat.Builder mBuilder = NotificationCompat.Builder mBuilder =
new NotificationCompat.Builder(ListenActivity.this) new NotificationCompat.Builder(ListenActivity.this)
.setOngoing(true) .setOngoing(true)
@@ -117,7 +112,6 @@ public class ListenActivity extends Activity
.setContentTitle(getString(R.string.app_name)) .setContentTitle(getString(R.string.app_name))
.setContentText(getString(R.string.listening)); .setContentText(getString(R.string.listening));
_mNotifyMgr.notify(mNotificationId, mBuilder.build()); _mNotifyMgr.notify(mNotificationId, mBuilder.build());
final TextView connectedText = (TextView) findViewById(R.id.connectedTo); final TextView connectedText = (TextView) findViewById(R.id.connectedTo);
@@ -125,8 +119,7 @@ public class ListenActivity extends Activity
final TextView statusText = (TextView) findViewById(R.id.textStatus); final TextView statusText = (TextView) findViewById(R.id.textStatus);
statusText.setText(R.string.listening); statusText.setText(R.string.listening);
}
});
_listenThread = new Thread(new Runnable() _listenThread = new Thread(new Runnable()
{ {

8
app/src/main/java/protect/babymonitor/MonitorActivity.java
View File

@@ -167,11 +167,6 @@ public class MonitorActivity extends Activity
}); });
_serviceThread.start(); _serviceThread.start();
MonitorActivity.this.runOnUiThread(new Runnable()
{
@Override
public void run()
{
final TextView addressText = (TextView) findViewById(R.id.address); final TextView addressText = (TextView) findViewById(R.id.address);
// Use the application context to get WifiManager, to avoid leak before Android 5.1 // Use the application context to get WifiManager, to avoid leak before Android 5.1
@@ -189,8 +184,7 @@ public class MonitorActivity extends Activity
{ {
addressText.setText(R.string.wifiNotConnected); addressText.setText(R.string.wifiNotConnected);
} }
}
});
} }
@Override @Override